-
Notifications
You must be signed in to change notification settings - Fork 784
Barebones openai agents tracer #3805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nts/= delete unnecessary file
…nts/events.yaml delete unnecessary file
…nts/metrics.yaml delete unnecessary file
…nts/registry.yaml delete unnecessary file
…nts/spans.yaml remove unncessary file
…m most; add enhanced_travel_planner and trace_collectors; update README
…mode returning [{"type":"text","content":"readacted"}] when sensitive capture disabled; add TODO to restore processors on uninstrument
…e in normalized output schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
instrumentation-genai/README.md
Outdated
| --------------- | ------------------ | --------------- | -------------- | | ||
| [opentelemetry-instrumentation-google-genai](./opentelemetry-instrumentation-google-genai) | google-genai >= 1.0.0 | No | development | ||
| [opentelemetry-instrumentation-langchain](./opentelemetry-instrumentation-langchain) | langchain >= 0.3.21 | No | development | ||
| [opentelemetry-instrumentation-openai-agents](./opentelemetry-instrumentation-openai-agents) | openai-agent >= 0.1.0 | Yes | development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to start the version at 2.x since opentelemetry-openai-agents namespace is already taken, similar to vertexai. @nirga H Is 2.x the agreed upon versioning for OpenTelemetry instrumentations to share the namespace, and how does opentelemetry
pypi account gain owner access to these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about version.
dependencies = [ | ||
"opentelemetry-api ~= 1.30", | ||
"opentelemetry-instrumentation ~= 0.51b0", | ||
"opentelemetry-semantic-conventions ~= 0.51b0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably require >= 0.58 if we want to start off with support for the latest experimental gen AI sem conventions, WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that sounds like a better idea. Will make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the change!
"Programming Language :: Python :: 3.13", | ||
] | ||
dependencies = [ | ||
"opentelemetry-api ~= 1.30", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend going >= 1.37, there's a bunch of recent changes for writing events via the logs API/sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nagkumar91 looks like you haven't pushed though :)
libraries = [ | ||
{ | ||
"library": "openai-agents >= 0.3.3", | ||
"instrumentation": "opentelemetry-instrumentation-openai-agents==0.1.0.dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest skip this for now, like the other ones: https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/scripts/generate_instrumentation_bootstrap.py#L74
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just update the file and run tox -e generate again
|
||
[project.optional-dependencies] | ||
instruments = [ | ||
"openai-agents >= 0.3.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"openai-agents >= 0.3.3", | |
"openai-agents >= 0.3.2", |
Other part of the code references 0.3.2.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.